New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-19142] Prompt user whether to add the job to the current view #2529
Conversation
what if the current view is based on a regex filter? |
If a regex is set then the checkbox will be unticked by default (see |
Naming of the file is inconsistent with the vast majority of existing Jelly files. ~1/6 have dashes, about half of them to separate a prefix ( I therefore recommend something like |
@daniel-beck Both fixed |
👍 I'm not sure I find the rule of checking/unchecking by default is definitely the right one. But as I can't come up with a better proposal, I'm fine with it. If someone finds a better way, it'll be quite easy to adjust as Vincent isolated that well in a small decision method. Also, used again |
I think the defaults here are sensible. It's definitely a major improvement over the current situation. Since the UI glitch has been resolved 👍 |
👍 |
https://issues.jenkins-ci.org/browse/JENKINS-19142
@jenkinsci/code-reviewers
This adds a checkbox in the new job screen, allowing the user to control whether the job will be added to the current view.